Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125028: Prohibit placeholders in partial keywords #126062

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

gh-125028: Prohibit placeholders in partial keywords #126062

wants to merge 16 commits into from
+37 −2

Conversation

dg-pb
Copy link
Contributor

@dg-pb dg-pb commented Oct 28, 2024 •
edited
Loading

@dg-pb dg-pb requested a review from rhettinger as a code owner October 28, 2024 06:53
@bedevere-app bedevere-app bot mentioned this pull request Oct 28, 2024
Open
@dg-pb dg-pb mentioned this pull request Oct 28, 2024
Closed
erlend-aasland
erlend-aasland reviewed Oct 28, 2024
View reviewed changes
Lib/functools.py Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
@dg-pb dg-pb marked this pull request as draft October 30, 2024 08:59
@dg-pb dg-pb marked this pull request as ready for review October 30, 2024 10:16
erlend-aasland
erlend-aasland reviewed Jan 4, 2025
View reviewed changes
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
dg-pb and others added 2 commits January 5, 2025 10:03
@dg-pb @erlend-aasland
Idiomatic C
5abc61e 
Co-authored-by: Erlend E. Aasland <[email protected]>
@dg-pb @erlend-aasland
remove unrelated changes
656361b 
Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
erlend-aasland reviewed Jan 5, 2025
View reviewed changes
Lib/test/test_functools.py Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
dg-pb and others added 2 commits January 5, 2025 14:56
erlend-aasland
erlend-aasland requested changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend Doc/library/functools.rst and Doc/whatsnew/3.14.rst as needed.

@bedevere-app
Copy link

bedevere-app bot commented Jan 5, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@dg-pb
Copy link
Contributor Author

dg-pb commented Jan 5, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jan 5, 2025

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from erlend-aasland January 5, 2025 21:40
@erlend-aasland
Copy link
Contributor

Thanks, looks good to me. I'd like Serhiy's eyes on it also.

serhiy-storchaka
serhiy-storchaka reviewed Jan 6, 2025
View reviewed changes
Lib/test/test_functools.py Show resolved Hide resolved
Lib/functools.py Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
@dg-pb dg-pb mentioned this pull request Jan 6, 2025
Open
serhiy-storchaka
serhiy-storchaka approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Lib/test/test_functools.py Outdated Show resolved Hide resolved
@dg-pb dg-pb mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyx1998 zhangyx1998 zhangyx1998 left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg-pb @erlend-aasland @serhiy-storchaka @zhangyx1998