gh-111178: fix UBSan failures for gdbmobject
#128178
Open
+20
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for something I thought of when I was doing those UBSan tasks:
AFAIR, I skipped the assert when the type is internal and dynamic (namely I used a simple pointer cast). For now, I suggest keeping the macro form since it wouldn't really matter if we just have a static inline function without the assertion check.
I've also suppressed an unused return value just for my IDE to be happy but I can revert the commit if needed.