Draft: gh-127119: Faster check for small ints in long_dealloc (debug) #128187
+52
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eendebakpt
commented
Dec 22, 2024
•
eendebakpt
commented
- Issue: Remove redundant small int check in long_dealloc #127119
… into small_int_immortal_v2
… into small_int_immortal_v2
Co-authored-by: Bénédikt Tran <[email protected]>
… into small_int_immortal_v2
Co-authored-by: Mark Shannon <[email protected]>
… into small_int_immortal_v2
Co-authored-by: Mark Shannon <[email protected]>
Co-authored-by: Mark Shannon <[email protected]>
Co-authored-by: Mark Shannon <[email protected]>
eendebakpt
force-pushed
the
small_int_immortal_v2_tst
branch
from
d89aa25 to
15023d5
Compare
eendebakpt
force-pushed
the
small_int_immortal_v2_tst
branch
from
15023d5 to
3a553d1
Compare
|
@eendebakpt I'm assuming this is only for CI triggers right? would it make sense to you to convert it into a draft? (just so that I'm not tempted to click on it) |
|
(You could have kept it opened but thanks for cleaning up the opened PRs xD) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.