-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128201: Fix DeprecationWarning
in Lib/test/test_pdb.py
#128202
base: main
Are you sure you want to change the base?
Conversation
DeprecationWarning
in Lib/test/test_pdb.py
DeprecationWarning
in Lib/test/test_pdb.py
Is this the correct way to fix it? I actually don't know what set policy does. Someone with asyncio expertise should check if this is needed or what's the modern way to write it. Replacing it with a "private" call might elimiate the warning but may not be the best way to fix this. |
If Can we also call the replacement? |
Initially I was thinking about a "default way" to fix that This one was accidentally omitted in #128024:
UPD: |
Okay I think the fix is okay at this point. However, is there an asyncio expert that can take a look at the testing code and see if this line is even needed? As there's no explicit code to change the policy. The testing code is pretty trivial, will a |
For pdb tests, |
test_pdb
raises aDeprecationWarning
#128201