-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128688 Introduce qualname in extra parameters providing qualified name including classname. #128634
base: main
Are you sure you want to change the base?
Conversation
NN---
commented
Jan 8, 2025
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Introduce qualified name instead of function name in logging #128688
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This requires a NEWS entry though. This is a new feature so we need a blurb and a What's New entry (in Doc/whatsnew/3.14.rst). This also requires the logging documentation to be updated. |
Maybe update the docstring with this change? - Find the stack frame of the caller so that we can note the source
- file name, line number and function name.
+ Find the stack frame of the caller so that we can note the source
+ file name, line number and function name (qualified name if
+ `self.use_qualname` is ``True`` , otherwise simple name). |
Well, it's not enough to update the docstring - the documentation should be updated (lots of people using the package wouldn't be looking at the source code), and also unit tests are needed. |