Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128688 Introduce qualname in extra parameters providing qualified name including classname. #128634

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NN---
Copy link

@NN--- NN--- commented Jan 8, 2025

Copy link

cpython-cla-bot bot commented Jan 8, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Lib/logging/__init__.py Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@NN--- NN--- changed the title Introduce qualname in extra parameters providing qualified name including classname. gh-128688 Introduce qualname in extra parameters providing qualified name including classname. Jan 9, 2025
@NN--- NN--- marked this pull request as ready for review January 9, 2025 19:57
@NN--- NN--- requested a review from vsajip as a code owner January 9, 2025 19:57
@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@NN--- NN--- requested a review from methane January 9, 2025 19:57
@picnixz
Copy link
Contributor

picnixz commented Jan 10, 2025

This requires a NEWS entry though. This is a new feature so we need a blurb and a What's New entry (in Doc/whatsnew/3.14.rst). This also requires the logging documentation to be updated.

@StanFromIreland
Copy link
Contributor

Maybe update the docstring with this change?

- Find the stack frame of the caller so that we can note the source
- file name, line number and function name.
+ Find the stack frame of the caller so that we can note the source
+ file name, line number and function name (qualified name if
+ `self.use_qualname`  is ``True`` , otherwise simple name).

@vsajip
Copy link
Member

vsajip commented Jan 10, 2025

Well, it's not enough to update the docstring - the documentation should be updated (lots of people using the package wouldn't be looking at the source code), and also unit tests are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants