Infra: Ignore certain commits when calculating the last modified date #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Converting to draft as this should not be merged before #3431) |
|
Should "Last modified:" be renamed as "Last substantive modified:"? I don't think so. You can mark edits on Wikipedia as "minor edits", but they still show up as "Last edited". I'd just leave it as is, let "Last modified" reflect reality, and people who click it can see the history and decide for themselves what is important for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3431.
Due to #3418, all dates in the footers of PEPs report that the PEP was last modified on 9 September 2023. Whilst this was expected, and is superficially correct, we really want to report the last substantive modification time.
This uses the comprehensive list of ignored commits from #3431 to display the most recent substantive modification of each PEP, which is what readers would expect.
A
📚 Documentation preview 📚: https://pep-previews--3432.org.readthedocs.build/