Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 756: PyUnicode_Export() #3960

Merged
merged 10 commits into from
Sep 14, 2024
Merged

PEP 756: PyUnicode_Export() #3960

merged 10 commits into from
Sep 14, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 13, 2024

peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
peps/pep-0756.rst Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Sep 13, 2024

And remember the CODEOWNERS entry (and for #3961).

@vstinner
Copy link
Member Author

@hugovk:

And remember the CODEOWNERS entry (and for #3961).

Oops, done.

I addressed most of your remarks.

About UCS-1, it doesn't exist in https://en.wikipedia.org/wiki/Universal_Coded_Character_Set. It's made up in Python and exists as the C type Py_UCS1. But I added hyphens to UCS names (UCS-1, UCS-2, UCS-4).

@vstinner vstinner marked this pull request as ready for review September 14, 2024 09:02
@vstinner vstinner requested a review from a team as a code owner September 14, 2024 09:02
@vstinner vstinner merged commit e82e1e3 into python:main Sep 14, 2024
6 checks passed
@vstinner vstinner deleted the pep756 branch September 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants