Add a pure python sql engine benchmark. #303
Conversation
There was a problem hiding this comment.
This is great, and thanks for the contribution. One concern I have is that this may have an impact on the existing sqlglot benchmarks, and thus make the results no longer comparable with already-collected data. We should see if those are affected in a statistically significant way, and if so, add this as a separate benchmark suite instead.
|
@mdboom how do you check that? the biggest change that would impact previous versions is that i upgraded sqlglot. but in terms of this test in isolation, i think the only impact may be in GC because it's a new test? |
tobymao
force-pushed
the
python-sql-engine
branch
from
8d43f22
to
2dc51b9
Compare
|
Yeah, the problem is exactly that you upgraded sqlglot over several versions. |
can't you just back test it and recompute the benchmarks with the new sqlglot version? the old versions of sqlglot don't have a sql engine |
No description provided.