Update python-docs-theme to work with Sphinx 5 & 6

[AA-Turner]

Updated remaining jQuery scripts to standard JavaScript, and a few fixes for CSS changes.

A

[AA-Turner]

Turns out this is required for Sphinx 5... python/cpython#99381

A

[pradyunsg]

LGTM

[ezio-melotti]

In addition to the inline comments, I have two generic comments:

• The use of semicolons at the end of the line seems inconsistent. Unless there is a specific reason to keep them, I would just remove them all.
• I would avoid the use of if (...) return; or if (...) break; or even if (...) some_functions(). The expression after the condition should go on a new line, and it should be surrounded by { }, e.g.:

  if (...) {
     ...
  }

---

Fun fact: I originally implemented both the collapsible sidebar (~12 years ago in python/cpython#47393) and the copybutton (~11 years ago in python/cpython@59dba38) and since then they have traveled around a number of dirs and repos. It's nice to see that in the meanwhile things got standardized and JS evolved to the point that JQuery is no longer needed.

[hugovk]

Is this ready to merge?

[hugovk]

Rebased on main to build RTD preview:

• https://python-docs-theme-previews--99.org.readthedocs.build/en/99/

And there's an error in the console:

sidebar.js:34 Uncaught TypeError: Cannot read properties of null (reading 'querySelector')
    at HTMLDocument.initialiseSidebar (sidebar.js:34:38)

From the last line of:

  const bodyWrapper = document.getElementsByClassName("bodywrapper")[0]
  const sidebar = document.getElementsByClassName("sphinxsidebar")[0]
  const sidebarWrapper = document.getElementsByClassName('sphinxsidebarwrapper')[0]
  const sidebarButton = document.getElementById("sidebarbutton")
  const sidebarArrow = sidebarButton.querySelector('span')

[AA-Turner]

Updated the JavaScript, the previous version was attempting to access an element that had yet to be created. Thank you for the review!

A

[hugovk]

Working fine now, thanks!

[JulienPalard]

I just built https://docs.python.org/3.12/ after merging this PR.

[AA-Turner]

I just built docs.python.org/3.12 after merging this PR.

Working for me in Firefox 112 on Windows! If you have time over the next few weeks, please would we be able to make a 2023.4 release, to unblock python/cpython#99381?

A

[JulienPalard]

Releasing: #126