Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort arrays in SBOM JSON data for reproducibility #95

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Sort arrays in SBOM JSON data for reproducibility #95

merged 2 commits into from
Feb 9, 2024

Conversation

sethmlarson
Copy link
Collaborator

This makes arrays in the SBOM JSON consistent regardless of how the internal workings of the script or filesystem/tarballs are structured. Tested manually by applying to the existing 3.12.2 SBOM and attempting to generate anew with the 3.12.2 tarball and confirmed that then only differences were the tool version (commit SHA) and creation date:

4c4
<     "created": "2024-02-08T22:18:26Z",
---
>     "created": "2024-02-06T20:56:29Z",
7c7
<       "Tool: ReleaseTools-5b7ef459c76de94be909b02087080b4cc8befeed\n"
---
>       "Tool: ReleaseTools-f39e1557464bc7d14019a88cb8257545ed4104f3\n"

hugovk
hugovk approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see tests too :)

@sethmlarson sethmlarson merged commit e2c2bb1 into python:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethmlarson @hugovk