pkg_resources: Types from assignments and aliases
#11511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Feb 29, 2024
| @@ -248,7 +326,7 @@ class NullProvider: | |||
| def metadata_listdir(self, name: str) -> list[str]: ... | |||
| def run_script(self, script_name: str, namespace: dict[str, Any]) -> None: ... | |||
|
|
|||
| # Doesn't actually extend NullProvider | |||
| # Doesn't actually extend NullProvider, solves a typing issue in pytype_test.py | |||
There was a problem hiding this comment.
idk if that's still true, but that was the original reasoning, where some method returned a Distribution which was missing a property that NullProvider has.
This comment has been minimized.
This comment has been minimized.
Avasam
changed the title
pkg_resoruces: Types from assignments and aliasespkg_resources: Types from assignments and aliases
| def get_supported_platform() -> str: ... | ||
| def compatible_platforms(provided: str | None, required: str | None) -> bool: ... | ||
| def get_default_cache() -> str: ... | ||
| def get_importer(path_item: str) -> _Importer: ... |
There was a problem hiding this comment.
You also removed this on another PR, not sure why.
Otherwise this PR looks good.
There was a problem hiding this comment.
It's a re-import, (moved all the way to the top of the file).
Both PRs touched it because this change was relevant to both (it's now an import alias and it removes the _Importer class)
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #11455
Updated types that are either simplified or improved by using an assignement