Use assignment instead of annotation in third party enums #11957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
May 18, 2024
| WORD: int | ||
| X: int | ||
| VERBOSE: int | ||
| A = RegexFlag.A |
There was a problem hiding this comment.
Should all of the module constants in this file be Final?
Suggested change
| A = RegexFlag.A | |
| A: Final = RegexFlag.A |
There was a problem hiding this comment.
Looks like pytype isn't happy about this change
There was a problem hiding this comment.
Ah well, thanks for trying! :-)
This comment has been minimized.
This comment has been minimized.
This reverts commit 1355aae.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
May 18, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11956.
This PR handles all third party stubs except Pillow and pygit2 that I'll change in a follow up.