Set max_renewable_life to 1 week for the MIT KDC #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Kieß <[email protected]>
steffen-kiess
force-pushed
the
mit-kdc-max_renewable_life
branch
from
1ebe756 to
d71bea0
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no
max_renewable_lifesetting for the MIT KDC, which the MIT KDC interprets as 0 seconds. This will cause problems when testing ticket renewal.This causes the tests with jborean93/pykrb5#40 to fail sometimes with the error message https://github.com/steffen-kiess/pykrb5/actions/runs/8299662077/job/22716417142:
The reason that it fails only sometimes is that when the renewal attempt happens in the same second when the ticket was generated, the renewal succeeds.