Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCE symbol name logic on macOS #348

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jborean93
Copy link
Contributor

Only use the private Apple symbol name for the DCE extension detection when using the actual GSS.Framework target. This will allow compiling this library against a custom MIT krb5 or Heimdal library on macOS with support for the normal IOV wrapping functions.

Fixes: #347

Only use the private Apple symbol name for the DCE extension detection
when using the actual GSS.Framework target. This will allow compiling
this library against a custom MIT krb5 or Heimdal library on macOS with
support for the normal IOV wrapping functions.

Signed-off-by: Jordan Borean <[email protected]>
Copy link
Contributor

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jborean93
Copy link
Contributor Author

Thanks for looking over this @simo5

@jborean93 jborean93 merged commit cf9a337 into pythongssapi:main Aug 27, 2024
44 checks passed
@jborean93 jborean93 deleted the dce-symbol branch August 27, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cred_store extension not supported on macOS
2 participants