Skip to content

Commit

Permalink
fix(evaluation): amended stress-des 5.3 decision
Browse files Browse the repository at this point in the history
  • Loading branch information
amyheather committed Aug 15, 2024
1 parent 579566e commit e468549
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
6 changes: 3 additions & 3 deletions evaluation/reporting.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ This page evaluates the extent to which the journal article meets the criteria f
Of the **24** items in the checklist:

* **14** were met fully (✅)
* **5** were partially met (🟡)
* **4** were not met (❌)
* **6** were partially met (🟡)
* **3** were not met (❌)
* **1** was not applicable (N/A)

| Item | Recommendation | Met by study? | Evidence |
Expand Down Expand Up @@ -48,7 +48,7 @@ Of the **24** items in the checklist:
| **Implementation** |
| 5.1 Software or programming language | State the operating system and version and build number.<br>State the name, version and build number of commercial or open source DES software that the model is implemented in.<br>State the name and version of general-purpose programming languages used (e.g. Python 3.5).<br>Where frameworks and libraries have been used provide all details including version numbers. | 🟡 Partially | Some details provided - `Methods: Statistics and Software`: "The DES model was built with Simmer (version 4.1.0), a DES package for R. The interactive web application was built with R-Shiny"<br><br>@huang_optimizing_2019 |
| 5.2 Random sampling | State the algorithm used to generate random samples in the software/programming language used e.g. Mersenne Twister.<br>If common random numbers are used, state how seeds (or random number streams) are distributed among sampling processes. | 🟡 Partially | Sampling described for arrivals but not for length of time with resources. Doesn't mention whether seeds are used.<br><br>`Methods: Model Properties: Patients`: "Patients are generated by a Poissone process with an inter-arrival time as specified in Table 1."<br>![Table 1. DES model inputs](../original_study/tab1.jpg)<br>@huang_optimizing_2019 |
| 5.3 Model execution | State the event processing mechanism used e.g. three phase, event, activity, process interaction.<br>*Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations.*<br>State all priority rules included if entities/activities compete for resources.<br>If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.) | ❌ Not met | - |
| 5.3 Model execution | State the event processing mechanism used e.g. three phase, event, activity, process interaction.<br>*Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations.*<br>State all priority rules included if entities/activities compete for resources.<br>If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.) | 🟡 Partially | Does not state event processing mechanism. Does describe priority rules - `Methods: Model Properties: Queueing` - e.g. "n our model, emergency IR and stroke patients have higher priority than elective patients for resources. Specifically, angioINRs are capable of both INR and IR procedures, although all patient types... |
| 5.4 System specification | State the model run time and specification of hardware used. This is particularly important for large scale models that require substantial computing power. For parallel, distributed and/or use grid or cloud computing, etc. state the details of all systems used in the implementation (processors, network, etc.) | ❌ Not met | - |
| **Code access** |
| 6.1 Computer model sharing statement | Describe how someone could obtain the model described in the paper, the simulation software and any other associated software (or hardware) needed to reproduce the results. Provide, where possible, the link and DOIs to these. | ✅ Fully | `Methods`: "The source code for the model is available at <https://github.com/shiweih/desECR> under a GNU General Public License."<br><br>`Methods: Statistics and Software`: "DES model was built with Simmer (version 4.1.0), a DES package for R. The interactive web application was built with R-Shiny"<br><br>`Discussion`: "The model is currently available online at <https://rebrand.ly/desECR11>" <br><br>@huang_optimizing_2019 |
Expand Down
2 changes: 1 addition & 1 deletion evaluation/reproduction_report.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ eval_dict = {
'STARS (optional)': [2, 0, 3, 0],
'Badges (criteria)': [3, 0, 9, 0],
'Badges (badges)': [0, 0, 12, 0],
'STRESS-DES': [14, 5, 4, 1],
'STRESS-DES': [14, 6, 3, 1],
'ISPOR-SDM': [7, 2, 7, 2]
}
eval_wide = pd.DataFrame(eval_dict, index=col).T
Expand Down
17 changes: 17 additions & 0 deletions logbook/posts/2024_08_15/index.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
title: "Day 15"
author: "Amy Heather"
date: "2024-08-15"
categories: [evaluation]
bibliography: ../../../quarto_site/references.bib
---

## Untimed: Amendment to evaluation

Revisiting the evaluation from each study, I spotted a change to make to the evaluation against STRESS-DES.

**Criteria:** "5.3 Model execution State the event processing mechanism used e.g. three phase, event, activity, process interaction. Note that in some commercial software the event processing mechanism may not be published. In these cases authors should adhere to item 5.1 software recommendations. State all priority rules included if entities/activities compete for resources. If the model is parallel, distributed and/or use grid or cloud computing, etc., state and preferably reference the technology used. For parallel and distributed simulations the time management algorithms used. If the HLA is used then state the version of the standard, which run-time infrastructure (and version), and any supporting documents (FOMs, etc.)" @monks_strengthening_2019

**Original decision:** ❌ Not met

**New decision:** 🟡 Partially. Does not state event processing mechanism. Does describe priority rules - `Methods: Model Properties: Queueing` - e.g. "n our model, emergency IR and stroke patients have higher priority than elective patients for resources. Specifically, angioINRs are capable of both INR and IR procedures, although all patient types..."

0 comments on commit e468549

Please sign in to comment.