Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for urls without http/s #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for urls without http/s #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd36f6c
added support for urls without http/s
SurajJadhav7 Nov 19, 2020
37e5590
added 1 blank line
SurajJadhav7 Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions readit/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,16 @@ def main(
for url_to_add in add:
url = url_to_add
try:
validate_url = requests.get(url)
validate_code = validate_url.status_code
if url.startswith(("http://", "https://")):
validate_code = requests.get(url).status_code
elif requests.get("http://" + url).status_code == 200:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

validate_code = 200
url = "http://" + url
elif requests.get("https://" + url).status_code == 200:
validate_code = 200
url = "https://" + url
else:
validate_code = 0
if validate_code == 200:
is_url_added = database_connection.add_url(url)
if is_url_added:
Expand Down Expand Up @@ -98,8 +106,16 @@ def main(
url_id = url_list[0]
url = url_list[1]
try:
validate_url = requests.get(url)
validate_code = validate_url.status_code
if url.startswith(("http://", "https://")):
validate_code = requests.get(url).status_code
elif requests.get("http://" + url).status_code == 200:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above 2 line code is sufficient. Don't need this.

validate_code = 200
url = "http://" + url
elif requests.get("https://" + url).status_code == 200:
validate_code = 200
url = "https://" + url
else:
validate_code = 0
if validate_code == 200:
is_url_updated = database_connection.update_url(url_id, url)
if is_url_updated:
Expand Down Expand Up @@ -183,8 +199,16 @@ def main(
for url_to_add in insert:
url = url_to_add
try:
validate_url = requests.get(url)
validate_code = validate_url.status_code
if url.startswith(("http://", "https://")):
validate_code = requests.get(url).status_code
elif requests.get("http://" + url).status_code == 200:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

validate_code = 200
url = "http://" + url
elif requests.get("https://" + url).status_code == 200:
validate_code = 200
url = "https://" + url
else:
validate_code = 0
if validate_code == 200:
is_url_added = database_connection.add_url(url)
if is_url_added:
Expand Down