Add PyTorch 2.5 to regression test #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1168
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 16b6aa7 with merge base eb1fb3a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Closed
|
I think this is mergeable since we pinned nightly PyTorch. Mind just rebasing to main so we can see the sparse failures go away |
gau-nernst
approved these changes
Oct 25, 2024
msaroufim
approved these changes
Oct 25, 2024
jerryzh168
reviewed
Oct 25, 2024
| @@ -104,7 +105,13 @@ | |||
| def _int8wo_api(mod): | |||
| if TORCH_VERSION_AT_LEAST_2_4: | |||
| quantize_(mod, int8_weight_only(), set_inductor_config=False) | |||
| if not TORCH_VERSION_AT_LEAST_2_5: | |||
| if ( | |||
There was a problem hiding this comment.
wow condition is becoming pretty complicated..
There was a problem hiding this comment.
yean, ensure as much as test combination has been covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #1100