Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SAM2-fast server improvements #1285

Merged
merged 55 commits into from
Nov 14, 2024
Merged

More SAM2-fast server improvements #1285

merged 55 commits into from
Nov 14, 2024

Conversation

cpuhrsch
Copy link
Contributor

RLEData, some reorder of filtering, more compile-able regions. Causes slight numerical differences across all test images, but passes unit tests bit perfectly. Improves perf from ~190ms to ~130ms in the furious case with an increase in number of mismatched mask count. Improves perf from ~390ms to ~320ms without changing the mismatched mask count.

Copy link

pytorch-bot bot commented Nov 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1285

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a4f929e with merge base e34c83f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2024
@cpuhrsch cpuhrsch added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Nov 14, 2024
@cpuhrsch cpuhrsch merged commit 06ad55a into pytorch:main Nov 14, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants