Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address CI test failures in pytorch/data #1219

Closed
wants to merge 5 commits into from
Closed

Address CI test failures in pytorch/data #1219

wants to merge 5 commits into from

Conversation

gokulavasan
Copy link
Contributor

@gokulavasan gokulavasan commented Jan 9, 2024 •
edited
Loading

Changes

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2024
NicolasHug
NicolasHug approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gokul

gokulavasan
gokulavasan commented Jan 9, 2024
View reviewed changes
.github/workflows/aistore_ci.yml
@@ -48,7 +48,7 @@ jobs:
pip3 install -r requirements.txt
pip3 install --pre torch -f "${{ steps.pytorch_channel.outputs.value }}"
- name: Run AIStore local deployment
uses: NVIDIA/aistore@master
uses: NVIDIA/aistore@main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any master branch in that repo, changed it to main

@gokulavasan
Copy link
Contributor Author

I will try and address the remaining failing CI tests in a separate PR, merging this for now

@gokulavasan gokulavasan changed the title Remove torchvision tests from torchdata domain ci Address CI test failures in pytorch/data Jan 10, 2024
@facebook-github-bot
Copy link
Contributor

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gokulavasan merged this pull request in d727f63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikayk kartikayk kartikayk approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gokulavasan @facebook-github-bot @huydhn @NicolasHug @kartikayk