Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove label filters for test ci #1254

Closed
wants to merge 2 commits into from
Closed

remove label filters for test ci #1254

wants to merge 2 commits into from

Conversation

andrewkho
Copy link
Contributor

@andrewkho andrewkho commented May 8, 2024 •
edited
Loading

Our tests are not being shown on PR creation because something in the filters disables them when facebook-github-bot adds the CLA Signed tag. Just disable the filters to match pytorch/pytorch repo setup

Changes

  • Remove label filters on CI
  • Bump actions/setup-python from v4 -> v5
  • Bump actions/checkout from v3 -> v4

@andrewkho andrewkho requested a review from gokulavasan May 8, 2024 23:13
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
@facebook-github-bot
Copy link
Contributor

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gokulavasan
Copy link
Contributor

@huydhn Tagging you for review as you might have some context on why this was done this way? Or do you think it is good to remove.

@andrewkho andrewkho requested a review from huydhn May 8, 2024 23:41
@andrewkho
Copy link
Contributor Author

Also bumping versions here instead of here: #1249

@facebook-github-bot
Copy link
Contributor

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

huydhn
huydhn approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. From what I see, this seems to be a way that torchdata uses to manually control what is run on the PR. Take ci.yml as an example, it says that the workflow would run when a PR is opened, synchronize (updated), reopened or when someone labels it with ciflow/something. I don't have the context on why it was setup as such, but it's better to get it up and running than racking our brain trying to figure out why :)

@andrewkho
Copy link
Contributor Author

Thanks @huydhn for weighing in!

@facebook-github-bot
Copy link
Contributor

@andrewkho merged this pull request in 11e16da.

@andrewkho andrewkho deleted the update-actions-disable-filters branch May 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@gokulavasan gokulavasan Awaiting requested review from gokulavasan

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkho @facebook-github-bot @gokulavasan @huydhn