Fix broken windows build #1320
Fix broken windows build #1320
Conversation
facebook-github-bot
added
the
CLA Signed
andrewkho
changed the base branch from
andrewkh/update-ci-python-versions
to
main
andrewkho
force-pushed
the
andrewkh/ignore-msvc-warning
branch
from
c16f6cb
to
d5dc7b2
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1320
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cd94f06 with merge base a629426 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
third_party/CMakeLists.txt
Outdated
| @@ -54,6 +54,9 @@ else() | |||
| else() | |||
| list(APPEND AWSSDK_LIBRARIES ${aws_cpp_sdk_INSTALL}/lib/lib${lib}.a) | |||
| endif() | |||
| if(MSVC) | |||
| target_compile_options(${lib} PRIVATE /W4 /WX) | |||
There was a problem hiding this comment.
Quick clarification, do we mean to make warnings surface better ? or suppress them ? (got confused by PR title 😄)
As far as I can tell /W4 should make even informational warnings surface. Source: https://learn.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=msvc-170
There was a problem hiding this comment.
Ah sorry there's a compiler flag that makes warnings get treated as errors. In this case it's a deprecation warning and just trying to get it to ignore, not sure the right incantation
|
LGTM! |
--------- Co-authored-by: andrewkh <[email protected]>
--------- Co-authored-by: andrewkh <[email protected]>
Windows build has been broken for a while on trunk, due to new MSVC deprecation warnings being treated by errors. It turns out the submodule pointer for aws-sdk-cpp hadn't been updated in a while. This PR updates it the pointer to 1.11.311, which can build on windows. Main branch does not build on MacOS due to a bug in cmake where it doesn't set the correct MACOSX_DEPLOYMENT_TARGET.