Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataloader v2 usage in data/benchmarks #1351

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

divyanshk
Copy link
Contributor

@divyanshk divyanshk commented Oct 31, 2024

Removes references to dataloader v2.

Fixes #{1350}

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2024
Copy link

pytorch-bot bot commented Oct 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1351

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cb615dd with merge base 7b0de83 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@divyanshk divyanshk marked this pull request as ready for review October 31, 2024 17:04
Copy link
Contributor

@andrewkho andrewkho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@divyanshk divyanshk merged commit b255542 into main Nov 1, 2024
43 checks passed
@divyanshk divyanshk deleted the divyanshk/cleaup-benchmarks branch November 1, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up data/benchmarks, deprecate datapipe references
3 participants