Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nullptr in glow/glow/tests/benchmark/ConvBench.cpp #6163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/benchmark/ConvBench.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ class ConvBench : public Benchmark {
virtual void run() override {
// biasWDims isn't used in libjit_conv2d_f, so we're passing NULL.
libjit_conv2d_f(outW.data(), inW.data(), filterW.data(), biasW.data(),
outWdims, inWdims, filterWdims, NULL, kernelSizes, strides,
pads, group, depthUnroll);
outWdims, inWdims, filterWdims, nullptr, kernelSizes,
strides, pads, group, depthUnroll);
}

virtual void teardown() override {}
Expand Down
4 changes: 2 additions & 2 deletions tests/unittests/OCLTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,14 @@ class OpenCLCommandQueuePoolTest : public ::testing::Test {
void SetUp() override {
// Get an OpenCL platform ID.
std::vector<cl_platform_id> platforms(1);
cl_int err = clGetPlatformIDs(1, platforms.data(), NULL);
cl_int err = clGetPlatformIDs(1, platforms.data(), nullptr);
ASSERT_EQ(err, CL_SUCCESS) << "clGetPlatformIDs failed.";

// Get an OpenCL device ID.
cl_platform_id platform_id_used = platforms[0];
std::vector<cl_device_id> devices(1);
err = clGetDeviceIDs(platform_id_used, CL_DEVICE_TYPE_ALL, 1,
devices.data(), NULL);
devices.data(), nullptr);
ASSERT_EQ(err, CL_SUCCESS) << "clGetDeviceIDs failed";

// Create an OpenCL context.
Expand Down
Loading