Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated style variable #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ain-soph
Copy link
Contributor

style variable is deprecated in sphinx 7.0.0. However, in current pytorch_sphinx_theme, we are still using it.

<link rel="stylesheet" href="{{ pathto('_static/' + style, 1) }}" type="text/css" />
<!-- <link rel="stylesheet" href="{{ pathto('_static/pygments.css', 1) }}" type="text/css" /> -->

Following is the solution from sphinx-rtd-theme:
https://github.com/readthedocs/sphinx_rtd_theme/blob/03a86b803cf7cf281748ef94345ba7c35953952a/sphinx_rtd_theme/layout.html#L26-L30

They add an if condition for compatibility with very old sphinx<4.0. I think we can just remove those codes.


https://www.sphinx-doc.org/en/master/changes.html

image

@svekars
Copy link
Contributor

svekars commented Dec 5, 2023

Sorry for the late response. I know this is a valid issue. Did you have a chance to test this against Sphinx version 5.0 and older? A lot of pytorch sites still use the older version.

@ain-soph
Copy link
Contributor Author

ain-soph commented Dec 7, 2023

@svekars Sorry that I don't have time to test it recently. If it's not in a hurry, I may test that during Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants