Skip to content

[BugFix] Avoid reshape(-1) for inputs to objectives modules (#2494) #6814

[BugFix] Avoid reshape(-1) for inputs to objectives modules (#2494)

[BugFix] Avoid reshape(-1) for inputs to objectives modules (#2494) #6814

Triggered via push October 15, 2024 12:56
Status Failure
Total duration 16m 4s
Artifacts

benchmarks.yml

on: push
CPU Pytest benchmark
15m 32s
CPU Pytest benchmark
GPU Pytest benchmark
15m 51s
GPU Pytest benchmark
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 3 warnings
CPU Pytest benchmark
# :warning: **Performance Alert** :warning: Possible performance regression was detected for benchmark **'CPU Benchmark Results'**. Benchmark result of this commit is worse than the previous benchmark result exceeding threshold `2`. | Benchmark suite | Current: 4736fac50e6408cdd03adbfdecee8e923016636e | Previous: 48606740d466085532c517cb49dd0281d2e87c07 | Ratio | |-|-|-|-| | `benchmarks/test_replaybuffer_benchmark.py::test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400]` | `33.51988179966991` iter/sec (`stddev: 0.18139682304628116`) | `213.54621168616438` iter/sec (`stddev: 0.0008217465351374432`) | `6.37` | This comment was automatically generated by [workflow](https://github.com/pytorch/rl/actions?query=workflow%3AContinuous%20Benchmark) using [github-action-benchmark](https://github.com/marketplace/actions/continuous-benchmark). CC: @vmoens Comment was generated at https://github.com/pytorch/rl/commit/4736fac50e6408cdd03adbfdecee8e923016636e#commitcomment-147953104
GPU Pytest benchmark
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
GPU Pytest benchmark
WARNING: The directory '/github/home/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
GPU Pytest benchmark
Command 'git' failed with args '-c user.name=github-action-benchmark -c [email protected] -c http.https://github.com/.extraheader= fetch ***github.com/pytorch/rl.git gh-pages:gh-pages': fatal: not a git repository (or any parent up to mount point /) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). : Error: The process '/usr/bin/git' failed with exit code 128
CPU Pytest benchmark
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
CPU Pytest benchmark
Performance alert! Previous value was 213.54621168616438 and current value is 33.51988179966991. It is 6.370732837377347x worse than previous exceeding a ratio threshold 2
GPU Pytest benchmark
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.