Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix "done" instead of "terminated" mistakes #1661

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

MarCnu
Copy link
Contributor

@MarCnu MarCnu commented Oct 29, 2023

Description

3 fixes
Fix twice an initialisation of terminated using tensordict.get(done).

Fix a call of function with parameter "terminated=done"

Motivation and Context

Most likely a copy pasting mistake during the terminated/done refactor

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

3 fixes
Fix twice an initialisation of terminated using tensordict.get(done).
Fix a call of function with parameter "terminated=done"
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2023
@vmoens vmoens added the bug Something isn't working label Oct 30, 2023
@vmoens vmoens linked an issue Oct 30, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's wait for the tests to pass!

@vmoens
Copy link
Contributor

vmoens commented Oct 30, 2023

The broken tests are either flaky (gym vec envs), known to be broken (habitat) or passing locally (exmples)

@vmoens vmoens merged commit 485cca2 into pytorch:main Oct 30, 2023
51 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix "done" instead of "terminated" mistakes
3 participants