Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Update dreamer example tests #1668

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[Minor] Update dreamer example tests #1668

merged 1 commit into from
Nov 2, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 2, 2023

A device argument is missing in dreamer's example and tests, which makes the code not runnable on machines without gpu.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2023
@vmoens vmoens added the quality code quality label Nov 2, 2023
@vmoens vmoens merged commit 8c89ead into main Nov 2, 2023
31 of 47 checks passed
@vmoens vmoens deleted the update_dreamer_test branch November 2, 2023 14:25
Copy link

github-actions bot commented Nov 2, 2023

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 68.1343ms 67.1704ms 14.8875 Ops/s 14.2423 Ops/s $\color{#35bf28}+4.53\%$
test_sync 38.7024ms 36.9630ms 27.0541 Ops/s 26.9355 Ops/s $\color{#35bf28}+0.44\%$
test_async 65.2578ms 36.2890ms 27.5566 Ops/s 26.4159 Ops/s $\color{#35bf28}+4.32\%$
test_simple 0.5103s 0.4709s 2.1236 Ops/s 2.1177 Ops/s $\color{#35bf28}+0.28\%$
test_transformed 0.6870s 0.6302s 1.5867 Ops/s 1.5460 Ops/s $\color{#35bf28}+2.63\%$
test_serial 1.4124s 1.3597s 0.7355 Ops/s 0.7243 Ops/s $\color{#35bf28}+1.54\%$
test_parallel 1.3899s 1.3399s 0.7463 Ops/s 0.7431 Ops/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-True-True-True] 0.1614ms 33.9244μs 29.4773 KOps/s 28.7842 KOps/s $\color{#35bf28}+2.41\%$
test_step_mdp_speed[True-True-True-True-False] 52.7580μs 19.3322μs 51.7272 KOps/s 51.4214 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[True-True-True-False-True] 78.9770μs 23.9893μs 41.6853 KOps/s 42.8070 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[True-True-True-False-False] 77.4720μs 13.0814μs 76.4445 KOps/s 75.8616 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[True-True-False-True-True] 85.8820μs 35.2479μs 28.3705 KOps/s 27.8456 KOps/s $\color{#35bf28}+1.89\%$
test_step_mdp_speed[True-True-False-True-False] 53.9700μs 20.9600μs 47.7099 KOps/s 47.7902 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[True-True-False-False-True] 65.6720μs 25.8430μs 38.6953 KOps/s 38.5637 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-False-False-False] 62.5670μs 14.9422μs 66.9245 KOps/s 67.1708 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[True-False-True-True-True] 80.5600μs 37.5055μs 26.6627 KOps/s 26.8806 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[True-False-True-True-False] 82.9750μs 22.6272μs 44.1945 KOps/s 44.6491 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[True-False-True-False-True] 57.2670μs 25.5223μs 39.1815 KOps/s 38.4079 KOps/s $\color{#35bf28}+2.01\%$
test_step_mdp_speed[True-False-True-False-False] 56.0740μs 14.8541μs 67.3217 KOps/s 67.8032 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-False-True-True] 0.1429ms 38.6052μs 25.9033 KOps/s 26.2767 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[True-False-False-True-False] 50.4640μs 23.6108μs 42.3535 KOps/s 40.1211 KOps/s $\textbf{\color{#35bf28}+5.56\%}$
test_step_mdp_speed[True-False-False-False-True] 67.1350μs 26.8784μs 37.2046 KOps/s 37.1638 KOps/s $\color{#35bf28}+0.11\%$
test_step_mdp_speed[True-False-False-False-False] 37.8510μs 16.2506μs 61.5364 KOps/s 62.5227 KOps/s $\color{#d91a1a}-1.58\%$
test_step_mdp_speed[False-True-True-True-True] 67.8360μs 37.2223μs 26.8656 KOps/s 26.7052 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[False-True-True-True-False] 59.6810μs 22.5426μs 44.3605 KOps/s 44.5160 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-True-False-True] 70.4110μs 28.0327μs 35.6727 KOps/s 34.8419 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-True-True-False-False] 48.5710μs 16.3688μs 61.0919 KOps/s 61.1458 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-True-False-True-True] 99.5560μs 38.4333μs 26.0191 KOps/s 25.6275 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[False-True-False-True-False] 74.7390μs 23.8199μs 41.9818 KOps/s 41.6207 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-True-False-False-True] 76.9130μs 30.2344μs 33.0749 KOps/s 33.8955 KOps/s $\color{#d91a1a}-2.42\%$
test_step_mdp_speed[False-True-False-False-False] 67.9170μs 17.8489μs 56.0260 KOps/s 56.5534 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[False-False-True-True-True] 97.5820μs 40.2842μs 24.8237 KOps/s 24.4347 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[False-False-True-True-False] 58.0880μs 25.1081μs 39.8278 KOps/s 39.4829 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-False-True-False-True] 81.3020μs 29.6038μs 33.7795 KOps/s 33.5275 KOps/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[False-False-True-False-False] 55.0220μs 17.5104μs 57.1088 KOps/s 56.6151 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-False-False-True-True] 82.0930μs 41.0171μs 24.3801 KOps/s 24.4305 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[False-False-False-True-False] 52.2370μs 26.3637μs 37.9310 KOps/s 37.6049 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-False-False-False-True] 74.3780μs 30.9399μs 32.3207 KOps/s 32.1574 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-False-False-False-False] 43.7620μs 18.8870μs 52.9464 KOps/s 51.2364 KOps/s $\color{#35bf28}+3.34\%$
test_values[generalized_advantage_estimate-True-True] 15.8029ms 12.1233ms 82.4858 Ops/s 81.7074 Ops/s $\color{#35bf28}+0.95\%$
test_values[vec_generalized_advantage_estimate-True-True] 34.6524ms 26.3549ms 37.9436 Ops/s 36.9197 Ops/s $\color{#35bf28}+2.77\%$
test_values[td0_return_estimate-False-False] 0.2477ms 0.1882ms 5.3135 KOps/s 5.1396 KOps/s $\color{#35bf28}+3.38\%$
test_values[td1_return_estimate-False-False] 26.4743ms 25.4421ms 39.3049 Ops/s 38.1764 Ops/s $\color{#35bf28}+2.96\%$
test_values[vec_td1_return_estimate-False-False] 34.5631ms 26.7124ms 37.4358 Ops/s 36.6831 Ops/s $\color{#35bf28}+2.05\%$
test_values[td_lambda_return_estimate-True-False] 36.4329ms 35.8628ms 27.8840 Ops/s 27.0932 Ops/s $\color{#35bf28}+2.92\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.3363ms 26.5062ms 37.7270 Ops/s 36.6054 Ops/s $\color{#35bf28}+3.06\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.1479ms 8.0217ms 124.6622 Ops/s 119.3652 Ops/s $\color{#35bf28}+4.44\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 10.0107ms 1.9800ms 505.0440 Ops/s 522.3895 Ops/s $\color{#d91a1a}-3.32\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4954ms 0.4295ms 2.3282 KOps/s 2.2595 KOps/s $\color{#35bf28}+3.04\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 0.1230s 46.5649ms 21.4754 Ops/s 23.8323 Ops/s $\textbf{\color{#d91a1a}-9.89\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 10.4617ms 2.5057ms 399.0844 Ops/s 397.6577 Ops/s $\color{#35bf28}+0.36\%$
test_dqn_speed 10.0553ms 1.8055ms 553.8662 Ops/s 543.3299 Ops/s $\color{#35bf28}+1.94\%$
test_ddpg_speed 11.2980ms 3.1092ms 321.6224 Ops/s 311.3031 Ops/s $\color{#35bf28}+3.31\%$
test_sac_speed 16.6728ms 8.9213ms 112.0918 Ops/s 104.5022 Ops/s $\textbf{\color{#35bf28}+7.26\%}$
test_redq_speed 27.1016ms 18.3601ms 54.4660 Ops/s 55.8502 Ops/s $\color{#d91a1a}-2.48\%$
test_redq_deprec_speed 23.8300ms 15.3307ms 65.2286 Ops/s 64.8896 Ops/s $\color{#35bf28}+0.52\%$
test_td3_speed 10.1430ms 9.0082ms 111.0096 Ops/s 109.5848 Ops/s $\color{#35bf28}+1.30\%$
test_cql_speed 44.2768ms 37.3155ms 26.7985 Ops/s 24.6095 Ops/s $\textbf{\color{#35bf28}+8.90\%}$
test_a2c_speed 19.0861ms 8.7952ms 113.6984 Ops/s 115.4421 Ops/s $\color{#d91a1a}-1.51\%$
test_ppo_speed 16.9362ms 8.8029ms 113.5995 Ops/s 113.1172 Ops/s $\color{#35bf28}+0.43\%$
test_reinforce_speed 15.6907ms 7.5801ms 131.9242 Ops/s 130.2330 Ops/s $\color{#35bf28}+1.30\%$
test_iql_speed 42.6258ms 33.5276ms 29.8261 Ops/s 29.2806 Ops/s $\color{#35bf28}+1.86\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8643ms 1.9085ms 523.9662 Ops/s 535.3555 Ops/s $\color{#d91a1a}-2.13\%$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 3.4036ms 2.0085ms 497.8821 Ops/s 512.6223 Ops/s $\color{#d91a1a}-2.88\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.0939ms 1.9682ms 508.0774 Ops/s 522.8338 Ops/s $\color{#d91a1a}-2.82\%$
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4151ms 1.8715ms 534.3211 Ops/s 426.9636 Ops/s $\textbf{\color{#35bf28}+25.14\%}$
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.7030ms 1.9440ms 514.3946 Ops/s 522.3162 Ops/s $\color{#d91a1a}-1.52\%$
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.2549ms 1.9497ms 512.9076 Ops/s 521.6756 Ops/s $\color{#d91a1a}-1.68\%$
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 0.2348s 2.3087ms 433.1368 Ops/s 540.7644 Ops/s $\textbf{\color{#d91a1a}-19.90\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.8668ms 1.9250ms 519.4917 Ops/s 454.9982 Ops/s $\textbf{\color{#35bf28}+14.17\%}$
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 2.9987ms 1.9153ms 522.1243 Ops/s 515.9667 Ops/s $\color{#35bf28}+1.19\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.4512ms 1.8221ms 548.8071 Ops/s 535.3422 Ops/s $\color{#35bf28}+2.52\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1357s 2.2478ms 444.8866 Ops/s 513.4154 Ops/s $\textbf{\color{#d91a1a}-13.35\%}$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 2.9930ms 1.9418ms 514.9803 Ops/s 509.5644 Ops/s $\color{#35bf28}+1.06\%$
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6885ms 1.8534ms 539.5471 Ops/s 547.2381 Ops/s $\color{#d91a1a}-1.41\%$
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.2913ms 1.9237ms 519.8418 Ops/s 512.9072 Ops/s $\color{#35bf28}+1.35\%$
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 2.8763ms 1.9198ms 520.8882 Ops/s 516.7315 Ops/s $\color{#35bf28}+0.80\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.1161ms 1.8649ms 536.2171 Ops/s 546.1278 Ops/s $\color{#d91a1a}-1.81\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.1002ms 1.9538ms 511.8152 Ops/s 513.9401 Ops/s $\color{#d91a1a}-0.41\%$
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.2797ms 1.9143ms 522.3736 Ops/s 513.2401 Ops/s $\color{#35bf28}+1.78\%$
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2415s 28.4793ms 35.1132 Ops/s 38.0297 Ops/s $\textbf{\color{#d91a1a}-7.67\%}$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1214s 23.8427ms 41.9415 Ops/s 38.6048 Ops/s $\textbf{\color{#35bf28}+8.64\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 0.1267s 26.3449ms 37.9580 Ops/s 42.4206 Ops/s $\textbf{\color{#d91a1a}-10.52\%}$
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1401s 24.3844ms 41.0098 Ops/s 39.6607 Ops/s $\color{#35bf28}+3.40\%$
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1237s 26.1347ms 38.2633 Ops/s 42.4635 Ops/s $\textbf{\color{#d91a1a}-9.89\%}$
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 0.1442s 25.0765ms 39.8779 Ops/s 38.7897 Ops/s $\color{#35bf28}+2.81\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1317s 26.3616ms 37.9339 Ops/s 38.2288 Ops/s $\color{#d91a1a}-0.77\%$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1314s 24.2112ms 41.3032 Ops/s 46.4040 Ops/s $\textbf{\color{#d91a1a}-10.99\%}$
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 0.1290s 26.5946ms 37.6016 Ops/s 37.6309 Ops/s $\color{#d91a1a}-0.08\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants