Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix documentation of threads for batched envs. #1776

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

skandermoalla
Copy link
Contributor

Shouldn't it be this instead?

Copy link

pytorch-bot bot commented Jan 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1776

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (11 Unrelated Failures)

As of commit 0fccdbe with merge base 1874e9a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2024
@vmoens vmoens added the documentation Improvements or additions to documentation label Jan 8, 2024
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 55faae1 into pytorch:main Jan 8, 2024
54 of 65 checks passed
@skandermoalla skandermoalla deleted the batched-env-doc branch January 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants