[aoti] Remove need for -l in cmake call #1159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1159
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 062dd87 with merge base 654bb03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
angelayi
force-pushed
the
angelayi/aoti_python
branch
2 times, most recently
from
937ab9a to
f285434
Compare
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
34259d4 to
23f96d4
Compare
angelayi
force-pushed
the
angelayi/aoti_python
branch
from
f285434 to
2c8b7b5
Compare
angelayi
force-pushed
the
angelayi/aoti_python
branch
4 times, most recently
from
b9d6ef5 to
eae63fe
Compare
angelayi
force-pushed
the
angelayi/aoti_python
branch
2 times, most recently
from
93e6727 to
5cd2862
Compare
|
@angelayi The rebase on this looks like a rough, wanna recreate? |
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
23f96d4 to
b2b93c5
Compare
Jack-Khuu
reviewed
Nov 5, 2024
| @@ -39,6 +39,7 @@ def export_for_server( | |||
| output_path: str = "model.pt2", | |||
| dynamic_shapes: bool = False, | |||
| package: bool = True, | |||
| metadata: Optional[Dict[str, str]] = None, | |||
There was a problem hiding this comment.
Suggested change
| metadata: Optional[Dict[str, str]] = None, | |
| metadata: Dict[str, str] = {}, |
We can delete metadata = metadata or {}
There was a problem hiding this comment.
general advice is to not have mutable structures as default args because they survive invocations =>
https://docs.python-guide.org/writing/gotchas/
Jack-Khuu
approved these changes
Nov 5, 2024
torchchat/export.py
Outdated
Comment on lines
452
to
454
| tokenizer_type = "0" | ||
| if tokenizer_args is not None: | ||
| tokenizer_type = "2" if tokenizer_args.is_sentencepiece else "3" |
There was a problem hiding this comment.
Suggested change
| tokenizer_type = "0" | |
| if tokenizer_args is not None: | |
| tokenizer_type = "2" if tokenizer_args.is_sentencepiece else "3" | |
| if tokenizer_args is None: | |
| tokenizer_type = "0" | |
| elif tokenizer_args.is_sentencepiece: | |
| tokenizer_type = "2" # Corresponding to llama2 | |
| else: | |
| tokenizer_type = "3" # Corresponding to llama3 |
nit: easier to add more options
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
7146029 to
7330b17
Compare
angelayi
commented
Nov 5, 2024
| path = package_aoti(output_path, path) | ||
|
|
There was a problem hiding this comment.
sorry, somehow my editor added on a bunch of formatting changes here.. hope it's not too confusing otherwise I can try to remove them.
There was a problem hiding this comment.
No worries, these are good lint fixes
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
7330b17 to
247fd20
Compare
Jack-Khuu
approved these changes
Nov 6, 2024
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
75908b8 to
e0299ff
Compare
angelayi
force-pushed
the
angelayi/aoti_metadata
branch
from
e0299ff to
062dd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for the
-lin the cmake call by storing the tokenizer type during export time in the PT2.Stacked on top of #896