Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last references to use_distributed argument #1353

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

mreso
Copy link
Contributor

@mreso mreso commented Nov 7, 2024

This PR removes the last references to the use_distributed argument which got replaced by --distributed

Copy link

pytorch-bot bot commented Nov 7, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1353

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 52b57ed with merge base 2fcc37c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 7, 2024
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for cleaning this up!

@lessw2020
Copy link
Contributor

Test failure seems unrelated:
Could not load library libnvrtc.so.12. Error: libnvrtc.so.12: cannot open shared object file: No such file or directory Could not load library libnvrtc.so. Error: libnvrtc.so: cannot open shared object file: No such file or directory

@mreso
Copy link
Contributor Author

mreso commented Nov 8, 2024

Test failure seems unrelated: Could not load library libnvrtc.so.12. Error: libnvrtc.so.12: cannot open shared object file: No such file or directory Could not load library libnvrtc.so. Error: libnvrtc.so: cannot open shared object file: No such file or directory

Yes, current main is also failing

Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreso
Copy link
Contributor Author

mreso commented Nov 8, 2024

@Jack-Khuu any thoughts on the test failure as its not PR related? Or can you by-pass it to merge? I think @byjlw did that for #1354 which failed with the same error but was merged.

@Jack-Khuu
Copy link
Contributor

I'll take a look this weekend, seems like there's an upstream GH CI bug. PR lgtm though

@Jack-Khuu Jack-Khuu merged commit 0f58543 into pytorch:main Nov 13, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants