-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create distributed.md #1438
base: main
Are you sure you want to change the base?
Create distributed.md #1438
Conversation
Initial documentation for use of distributed inference w/ torchchat. @mreso please review and update as appropriate.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1438
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Add support for extracting distributed inference tests in run-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much for writing it up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikekgfb looks good, the response of the server is a bit different but thats true for the non distributed case too.
docs/distributed.md
Outdated
<!-- | ||
[skip default]: begin | ||
## Generate output (requires testing and review by mreso) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- | |
[skip default]: begin | |
## Generate output (requires testing and review by mreso) | |
<!-- | |
[skip default]: begin | |
## Generate output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that works
Co-authored-by: Matthias Reso <[email protected]>
Co-authored-by: Matthias Reso <[email protected]>
Uncommenting section about generate subcommand w/ distributed inference after review by @mreso Also, Added HF login to make this fully self-contained
Wording
Wording and formatting
Initial documentation for use of distributed inference w/ torchchat. @mreso @lessw2020 @kwen2501 please review and update as appropriate.