Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu+macos14 #19

Closed
wants to merge 5 commits into from
Closed

Ubuntu+macos14 #19

wants to merge 5 commits into from

Conversation

mikekgfb
Copy link
Contributor

@mikekgfb mikekgfb commented Apr 3, 2024

improve coverage using ubuntiu and mac with apple silicon

@mikekgfb mikekgfb requested a review from malfet April 3, 2024 00:49
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 3, 2024
@mikekgfb mikekgfb requested a review from metascroy April 3, 2024 00:49
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use matrix:rather than duplicate workflows, see https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs

@mikekgfb
Copy link
Contributor Author

mikekgfb commented Apr 5, 2024

Closed, resolved by matrix spec for compile.yml workflow, and a macos split-off (sans compile jobs because OMP not working properly)

@mikekgfb mikekgfb closed this Apr 5, 2024
@malfet malfet deleted the ubuntu+macos14 branch July 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants