-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements #764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
May 12, 2024
mikekgfb
requested review from
larryliu0820,
iseeyuan,
manuelcandales and
metascroy
May 12, 2024 17:40
iseeyuan
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. May need to merge with #763 because there's some overlap.
Thank you @iseeyuan ! |
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* minimal example for enabling Andrej's runner, from commit 2d47702 * Minimal example * Documentation improvements to align documentation with changes in code base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 - Documentation improvements to align documentation with changes in code base
2 - Move a reference to the Android example and to docs/Android.md int the empty README section on Android