Skip to content

Commit

Permalink
Migrate Batch integration tests to use AWS resources in different reg…
Browse files Browse the repository at this point in the history
…ion (#769) (#769)

Summary:
Pull Request resolved: #769

Use us-west-1 resources as part of Devops efforts.

The resources will mirror original state and once things are stable we can turn off original region/resources.

Differential Revision: D49363140

fbshipit-source-id: b5be6ca43e90bf4cbc8bf081aa29a9c8d64ac5e1
  • Loading branch information
kurman authored Sep 21, 2023
1 parent a45c4ca commit a69bb05
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/aws-batch-integration-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,22 @@ jobs:
- name: Configure AWS Credentials
uses: aws-actions/[email protected]
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-region: us-west-1
role-to-assume: ${{ secrets.TF_AWS_ROLE_ARN }}
role-session-name: github-torchx
continue-on-error: true
- name: Configure Docker
run: |
set -eux
aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin 495572122715.dkr.ecr.us-west-2.amazonaws.com
aws ecr get-login-password --region us-west-1 | docker login --username AWS --password-stdin 495572122715.dkr.ecr.us-west-1.amazonaws.com
continue-on-error: true
- name: Install dependencies
run: |
set -eux
pip install -e .[dev]
- name: Run AWS Batch Integration Tests
env:
AWS_ROLE_ARN: ${{ secrets.AWS_ROLE_ARN }}
AWS_ROLE_ARN: ${{ secrets.TF_AWS_ROLE_ARN }}
run: |
set -ex
Expand Down
2 changes: 1 addition & 1 deletion scripts/awsbatchint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cd "$DIR"
cat <<EOT > .torchxconfig
[aws_batch]
queue=torchx
image_repo=495572122715.dkr.ecr.us-west-2.amazonaws.com/torchx/integration-tests
image_repo=495572122715.dkr.ecr.us-west-1.amazonaws.com/torchx/integration-tests
EOT

cat <<EOT > main.py
Expand Down

0 comments on commit a69bb05

Please sign in to comment.