Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use larger instances to avoid docker disk space issues #745

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

d4l3k
Copy link
Contributor

@d4l3k d4l3k commented Jul 26, 2023

Resolves issues related to docker build size.

Test plan:

CI

@d4l3k d4l3k requested a review from kiukchung July 26, 2023 06:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2023
@d4l3k d4l3k added docker and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #745 (4f252ac) into main (a17e427) will increase coverage by 1.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   91.06%   92.77%   +1.71%     
==========================================
  Files          96       96              
  Lines        6063     6063              
==========================================
+ Hits         5521     5625     +104     
+ Misses        542      438     -104     
Flag Coverage Δ
unittests 92.77% <ø> (+1.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d4l3k
Copy link
Contributor Author

d4l3k commented Jul 26, 2023

@kiukchung CI only changes, merging

@d4l3k d4l3k merged commit 1a8806d into main Jul 26, 2023
19 of 22 checks passed
@d4l3k d4l3k deleted the fix-ci branch July 26, 2023 06:36
KPostOffice pushed a commit to KPostOffice/torchx that referenced this pull request Sep 7, 2023
MichaelClifford pushed a commit to project-codeflare/torchx that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants