Log cpu and wall time for torchx events #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48375892 |
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 92.80% 92.81% +0.01%
==========================================
Files 96 96
Lines 6071 6080 +9
==========================================
+ Hits 5634 5643 +9
Misses 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kurman
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Can you split meta changes into a separate diff from this OSS changes to pass following check: https://github.com/pytorch/torchx/pull/754/checks?check_run_id=15930598973?
manav-a
added a commit
to manav-a/torchx
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: pytorch#754 This diff adds support to log cpu and wall times for torchx events. These numbers can provide an over all time to submit/launch estimate. Will export this diff to github as well after I have landed the sync diff in the this stack Reviewed By: kurman Differential Revision: D48375892 fbshipit-source-id: c2d20deb38649dc3cc9fa4c5fe9dff823d1a173a
manav-a
force-pushed
the
export-D48375892
branch
from
4a8097b
to
33ef77c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48375892 |
|
@kurman split the diff out to just have OSS changes |
Summary: Pull Request resolved: pytorch#754 This diff adds support to log cpu and wall times for torchx events. These numbers can provide an over all time to submit/launch estimate. Will export this diff to github as well after I have landed the sync diff in the this stack Reviewed By: kurman Differential Revision: D48375892 fbshipit-source-id: ac5daa231da2adb707b0a8c39e4a2526b4595895
|
This pull request was exported from Phabricator. Differential Revision: D48375892 |
manav-a
force-pushed
the
export-D48375892
branch
from
33ef77c
to
6618b20
Compare
kurman
reviewed
Aug 16, 2023
There was a problem hiding this comment.
@manav-a Do you mind looking at failures in unit test: https://github.com/pytorch/torchx/actions/runs/5881853738/job/15951156976?pr=754?
kurman
approved these changes
Aug 16, 2023
KPostOffice
pushed a commit
to KPostOffice/torchx
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: pytorch#754 This diff adds support to log cpu and wall times for torchx events. These numbers can provide an over all time to submit/launch estimate. Will export this diff to github as well after I have landed the sync diff in the this stack Reviewed By: kurman Differential Revision: D48375892 fbshipit-source-id: ac5daa231da2adb707b0a8c39e4a2526b4595895
MichaelClifford
pushed a commit
to project-codeflare/torchx
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: pytorch#754 This diff adds support to log cpu and wall times for torchx events. These numbers can provide an over all time to submit/launch estimate. Will export this diff to github as well after I have landed the sync diff in the this stack Reviewed By: kurman Differential Revision: D48375892 fbshipit-source-id: ac5daa231da2adb707b0a8c39e4a2526b4595895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support to log cpu and wall times for torchx events. These numbers can provide an over all time to submit/launch estimate.
Will export this diff to github as well after I have landed the sync diff in the this stack
Reviewed By: kurman
Differential Revision: D48375892