Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #778 #779

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fixes #778 #779

merged 1 commit into from
Oct 19, 2023

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Oct 17, 2023

adding EFA devices to AWS named_resources

Test plan:

  • added new assertions to existing AWS named_resources tests

adding EFA devices to AWS named_resources
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2023
@clumsy
Copy link
Contributor Author

clumsy commented Oct 17, 2023

For your consideration, @kiukchung

@kiukchung
Copy link
Collaborator

lgtm thanks for the PR! Waiting for CI to pass before merging

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #779 (45eb335) into main (13a4787) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          96       96           
  Lines        6098     6099    +1     
=======================================
+ Hits         5664     5665    +1     
  Misses        434      434           
Flag Coverage Δ
unittests 92.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
torchx/specs/named_resources_aws.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@clumsy
Copy link
Contributor Author

clumsy commented Oct 18, 2023

Fixed the formatting to address linter error, @kiukchung.

@clumsy
Copy link
Contributor Author

clumsy commented Oct 18, 2023

Let me know if any changes are needed, @kiukchung. The tests seem to pass.

@kiukchung kiukchung merged commit a711634 into pytorch:main Oct 19, 2023
24 checks passed
@clumsy clumsy deleted the feature/778 branch October 19, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants