Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken pyre in CI #788

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix broken pyre in CI #788

merged 1 commit into from
Nov 3, 2023

Conversation

kiukchung
Copy link
Collaborator

Fixes pyre checks broken in main due to fsspec being updated to 2023.1.0.
https://github.com/pytorch/torchx/actions/runs/6734942127/job/18306950235

Oddly, pyre checks passed in the PR (see: https://github.com/pytorch/torchx/actions/runs/6698472480) b/c for some reason pip decided to resolve to s3fs-0.6.0 (should've been s3fs-2023.1.0) when running pyre checks from the PR but s3fs-2023.1.0 when running pre checks from main

Test plan:

cd ~/workspace/torchx
pip install -U -r dev-requirements.txt
pyre --noninteractive check
2023-11-02 16:50:09,626 [PID 3429811] SUCCESS No type errors found

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 2, 2023
@kiukchung kiukchung merged commit fe6354d into main Nov 3, 2023
20 of 22 checks passed
@kiukchung kiukchung deleted the kiuk-dev branch November 3, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants