updating EFA_DEVICE details for AWS resources #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
For your consideration, @kiukchung |
clumsy
force-pushed
the
fix/update_aws_resources_efa
branch
from
2f20077
to
549d4f8
Compare
|
LGTM, looks like there is a rebase conflict. Happy to merge once you've resolved it! |
clumsy
force-pushed
the
fix/update_aws_resources_efa
branch
from
549d4f8
to
a69df07
Compare
|
I fixed the conflict, @kiukchung. Thanks! |
|
Bumping this one in case it got slipped through the cracks, @kiukchung |
|
LGTM thanks for the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of EFA-enabled devices for existing AWS resources is not up-to-date. Adding missing details according to https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/efa.html#efa-instance-types
Note that the number of devices matches the number of NICs: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-eni.html#network-cards
Test plan:
N/A