Follow python logging best practice in torchx/runner/events/... #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51381654 |
…rch#794) Summary: Do not set the log level or filters of either root or module-level loggers. Instead, configure this on each handler. Reviewed By: AndreasBackx Differential Revision: D51381654
gunchu
force-pushed
the
export-D51381654
branch
from
3fc8622
to
b3d00fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51381654 |
|
LGTM thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Do not set the log level or filters of either root or module-level loggers. Instead, configure this on each handler.
Reviewed By: AndreasBackx
Differential Revision: D51381654