Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NamedTuple for Tuple from parsing AppHandle #800

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

bobyangyf
Copy link
Contributor

Summary: Stricter types and better IDE hints via namedtuple over tuple

Differential Revision: D52092870

Summary: Stricter types and better IDE hints via namedtuple over tuple

Differential Revision: D52092870
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52092870

@kiukchung
Copy link
Collaborator

lgtm thanks

@kiukchung kiukchung merged commit 9d5e3c5 into pytorch:main Dec 18, 2023
20 of 23 checks passed
@bobyangyf bobyangyf deleted the export-D52092870 branch December 19, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants