Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "torchx/schedulers" #812

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Revert "torchx/schedulers" #812

merged 1 commit into from
Jan 30, 2024

Conversation

kiukchung
Copy link
Collaborator

This reverts commit 19497eb.

Causes pyre checks to fail

Test plan:

CI

This reverts commit 19497eb.
@kiukchung kiukchung requested a review from d4l3k January 30, 2024 18:08
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2024
Copy link
Contributor

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm -- are we on an older version of pyre?

@kiukchung kiukchung merged commit 1a8e1eb into main Jan 30, 2024
19 of 22 checks passed
@kiukchung kiukchung deleted the kiuk-dev branch January 30, 2024 18:27
@kiukchung
Copy link
Collaborator Author

Lgtm -- are we on an older version of pyre?

Looks like we'd have to go back to pyre-check-nightly to make the commit this PR reverts work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants