Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchx/release][0.7.0] post release version bump to 0.8.0dev0 #934

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[torchx/release][0.7.0] post release version bump to 0.8.0dev0 #934

merged 1 commit into from
Jul 17, 2024

Conversation

yikaiMeta
Copy link
Contributor

as title.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2024
@manav-a
Copy link
Contributor

manav-a commented Jul 17, 2024

Can you check why unit tests are failing?

@yikaiMeta
Copy link
Contributor Author

yikaiMeta commented Jul 17, 2024 •
edited
Loading

Can you check why unit tests are failing?

These errors are expected and are known issues.
After we bump the version, docker show errors like “manifest unknown” because they expect the new version of torchx image (the one being released) to be available already to run the tests.

We can ignore this error. After merging the PR, we can rebuild the image and test should pass.

andywag
andywag approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yikaiMeta yikaiMeta merged commit 512e40d into main Jul 17, 2024
15 of 22 checks passed
@yikaiMeta yikaiMeta deleted the yikaiMeta-dev1 branch July 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywag andywag andywag approved these changes

@ishachirimar ishachirimar ishachirimar approved these changes

@manav-a manav-a manav-a approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yikaiMeta @manav-a @andywag @ishachirimar @facebook-github-bot