Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Workspace build for TorchX #965

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

andywag
Copy link
Contributor

@andywag andywag commented Oct 14, 2024

Summary:
Option to build workspace independently of scheduler with async option.

First Cut to get agreement oninterface

Differential Revision: D63145971

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63145971

andywag added a commit to andywag/torchx that referenced this pull request Oct 14, 2024
Summary:

Option to build workspace independently of scheduler with async option.

Differential Revision: D63145971
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63145971

andywag added a commit to andywag/torchx that referenced this pull request Oct 14, 2024
Summary:

Option to build workspace independently of scheduler with async option.

Differential Revision: D63145971
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63145971

andywag added a commit to andywag/torchx that referenced this pull request Oct 14, 2024
Summary:

Option to build workspace independently of scheduler with async option.

Differential Revision: D63145971
Summary:
Pull Request resolved: pytorch#965

Option to build workspace independently of scheduler with async option.

Differential Revision: D63145971
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63145971

Copy link
Contributor

@Sanjay-Ganeshan Sanjay-Ganeshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the second class is necessary because "default" typing doesn't work in the relevant versions of Python

@facebook-github-bot facebook-github-bot merged commit 3855ae4 into pytorch:main Oct 15, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants