[OpenXLA|TSL] Replace tsl/platform/stringpiece.h with absl/strings/string_view.h
#6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfeiBai
changed the title
tsl/platform/stringpiece.h with absl/strings/string_view.h
ManfeiBai
force-pushed
the
ManfeiBai-patch-77
branch
from
f22baef
to
359d18b
Compare
ManfeiBai
changed the title
tsl/platform/stringpiece.h with absl/strings/string_view.htsl/platform/stringpiece.h with absl/strings/string_view.h
alanwaketan
reviewed
Mar 6, 2024
Thanks for the suggestion, and updated to std::string_view due to absl's defination cc @ddunl |
alanwaketan
approved these changes
Mar 6, 2024
ManfeiBai
changed the title
tsl/platform/stringpiece.h with absl/strings/string_view.htsl/platform/stringpiece.h with absl/strings/string_view.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-change for #6535
cc @ddunl