Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combined GRIB reader for both SEVIRI and FCI L2 products #2717

Merged
merged 28 commits into from
Oct 16, 2024

Merge branch 'pytroll:main' into main

12f1860
Select commit
Loading
Failed to load commit list.
Merged

Add combined GRIB reader for both SEVIRI and FCI L2 products #2717

Merge branch 'pytroll:main' into main
12f1860
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jul 1, 2024 in 12m 3s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.39 (8.55 -> 8.94)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_eum_l2_grib.py: TestEUML2GribFileHandler.test_seviri_data_reading
  • Large Method test_eum_l2_grib.py: TestEUML2GribFileHandler.test_fci_data_reading

Annotations

Check warning on line 203 in satpy/tests/reader_tests/test_eum_l2_grib.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TestEUML2GribFileHandler.test_seviri_data_reading has 72 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 299 in satpy/tests/reader_tests/test_eum_l2_grib.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TestEUML2GribFileHandler.test_fci_data_reading has 71 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.