Adapt reader mviri_l1b_fiduceo_nc #2802
Open
+187
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martin Raspaud <[email protected]>
|
Also I noticed that space pixels now have some finite values (instead of NaN), because |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
- Coverage 96.06% 96.03% -0.04%
==========================================
Files 370 373 +3
Lines 54320 54464 +144
==========================================
+ Hits 52185 52305 +120
- Misses 2135 2159 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ead_error Conflicts: satpy/readers/mviri_l1b_fiduceo_nc.py
sfinkens
reviewed
May 24, 2024
sfinkens
reviewed
May 29, 2024
sfinkens
reviewed
May 29, 2024
|
The test for the duplicate dimensions still needs to be added. |
small fix to DataWrapper._decode_cf()
adds support for filenames of MVIRI FCDR L1.5 release 2
sfinkens
reviewed
Jun 12, 2024
sfinkens
reviewed
Jun 12, 2024
…ing dataset; also rename dimension "channel"
…; moved decoding into separate method of DatasetWrapper
sfinkens
reviewed
Sep 4, 2024
- include u_independent_toa_bidirectional_reflectance in tests - patch decode_cf/fix_duplicate_dimensions in test_reassign_coords()
sfinkens
reviewed
Sep 19, 2024
|
Let's see if we can make CodeScene happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the mviri_l1b_fiduceo_nc reader when being used with a new xarray version (2024.3.0). When using the original reader, a ValueError about not being able to decode the times is thrown. The file is now opened without decoding. The decoding is now done in DatasetWrapper()._decode_cf(). The time is decoded separatly from the other data values. FillValues for the time are recognized to replace time values with NaT and time is decoded using the offset values included within the attributes.
Also, opening the dataset using chunks is deactivated because the input files contains dimensions of the same name which cannot be processed by xarray at the moment. The chunking as well as renaming the dimensions is also performed in DatsetWrapper().
AUTHORS.mdif not there already