Enhance support for FY-3F/MERSI-3 #2861
Open
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jul 26, 2024 in 44s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.16 (9.88 -> 9.73)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method mersi_l1b.py: MERSIL1B._get_rad_dataset
- Complex Conditional mersi_l1b.py: MERSIL1B._get_rad_dataset
Annotations
Check warning on line 246 in satpy/readers/mersi_l1b.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
MERSIL1B._get_rad_dataset has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 244 in satpy/readers/mersi_l1b.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
MERSIL1B._get_rad_dataset has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Loading