Add Cloud_Optical_Thickness to viirs_l2.yaml #2885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
reviewed
Aug 23, 2024
| @@ -104,6 +104,15 @@ datasets: | |||
| file_type: cldprop_l2_viirs | |||
| standard_name: cloud_top_height | |||
|
|
|||
| Cloud_Optical_Thickness: | |||
| name: Cloud_Optical_Thickness | |||
| long_name: Cloud Optical Thickness two-channel retrieval using 2.2 um and either 0.65 um, 0.86 um or 1.24um (specified in Quality_Assurance) from best points: not failed in any way, not marked for clear sky restoral | |||
There was a problem hiding this comment.
If this value is in the file I don't think it should be needed here if the python code pulls it from the file and puts in in the DataArray's .attrs. If it is needed here, then it should be surrounded by double quotes:
Suggested change
| long_name: Cloud Optical Thickness two-channel retrieval using 2.2 um and either 0.65 um, 0.86 um or 1.24um (specified in Quality_Assurance) from best points: not failed in any way, not marked for clear sky restoral | |
| long_name: "Cloud Optical Thickness two-channel retrieval using 2.2 um and either 0.65 um, 0.86 um or 1.24um (specified in Quality_Assurance) from best points: not failed in any way, not marked for clear sky restoral" |
djhoese
reviewed
Aug 23, 2024
| Cloud_Optical_Thickness: | ||
| name: Cloud_Optical_Thickness | ||
| long_name: Cloud Optical Thickness two-channel retrieval using 2.2 um and either 0.65 um, 0.86 um or 1.24um (specified in Quality_Assurance) from best points: not failed in any way, not marked for clear sky restoral | ||
| units: '1' |
There was a problem hiding this comment.
I'm not sure how yaml treats single quotes, but let's say for consistency sake we make them all double:
Suggested change
| units: '1' | |
| units: "1" |
djhoese
requested changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cloud optical thickness derived from the two channel retrieval to the CLDPROP_L2 reader of VIIRS.
AUTHORS.mdif not there already