Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix the VIIRS lowres version of the day-microphysics. #2957

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

adybbroe
Copy link
Contributor

This PR fixes a bug with the VIIRS low-resolution day-microphysics RGB using M-band.

It should use only M-bands! Currently it use the default nir-refelctance dataset, and that will then use the I-bands to try derive this. It should be forced to using the M bands.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

It should use only M-bands!

Signed-off-by: Adam.Dybbroe <[email protected]>
@adybbroe
Copy link
Contributor Author

This is what I saw:

[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delaying generation of DataID(name='M12', wavelength=WavelengthRange(min=3.61, central=3.7, max=3.79, unit='µm'), resolution=742, calibration=<2>, modifiers=('nir_reflectance',)) because of incompatible areas
[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delaying generation of DataID(name='day_microphysics') because of dependency's delayed generation: DataID(name='M15', wavelength=WavelengthRange(min=10.263, central=10.763, max=11.263, unit='µm'), resolution=742, calibration=<2>, modifiers=())
[DEBUG: 2024-10-25 15:10:15 : satpy.scene] Delayed prerequisite for 'DataID(name='day_microphysics')': 'DataID(name='M15', wavelength=WavelengthRange(min=10.263, central=10.763, max=11.263, unit='µm'), resolution=742, calibration=<2>, modifiers=())'
[WARNING: 2024-10-25 15:10:15 : satpy.scene] The following datasets were not created and may require resampling to be generated: DataID(name='day_microphysics')
[DEBUG: 2024-10-25 15:10:15 : asyncio] Using selector: EpollSelector

Was puzzled why it delayed the creation of this, as I expected it to only use M-bands. There is a day_microphysics_hires if you specifically want the high res version using I-bands. So I expected this one to use M-bands only!

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (118fc93) to head (d6b8d01).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2957   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         377      377           
  Lines       55110    55125   +15     
=======================================
+ Hits        52960    52975   +15     
  Misses       2150     2150           
Flag Coverage Δ
behaviourtests 3.94% <ø> (-0.01%) ⬇️
unittests 96.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11519400125

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.206%

Totals Coverage Status
Change from base Build 11519299470: 0.0%
Covered Lines: 53219
Relevant Lines: 55318

💛 - Coveralls

@pnuu pnuu merged commit e0eb086 into pytroll:main Oct 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants