-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix the VIIRS lowres version of the day-microphysics. #2957
Conversation
It should use only M-bands! Signed-off-by: Adam.Dybbroe <[email protected]>
This is what I saw:
Was puzzled why it delayed the creation of this, as I expected it to only use M-bands. There is a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 377 377
Lines 55110 55125 +15
=======================================
+ Hits 52960 52975 +15
Misses 2150 2150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Test Coverage Report for Build 11519400125Details
💛 - Coveralls |
This PR fixes a bug with the VIIRS low-resolution day-microphysics RGB using M-band.
It should use only M-bands! Currently it use the default nir-refelctance dataset, and that will then use the I-bands to try derive this. It should be forced to using the M bands.
AUTHORS.md
if not there already